fix: change workspaceFolders capability to boolean for LSP servers#1929
Merged
tanzhenxin merged 1 commit intoQwenLM:mainfrom Feb 27, 2026
Merged
Conversation
Fixes #1748 - gopls failed to start with JSON RPC parse error. The workspaceFolders capability was incorrectly sent as an object { supported: true } instead of a boolean true, causing gopls to fail with 'cannot unmarshal object into... bool'.
TheForgivenOne
requested review from
DennisYu07,
LaZzyMan,
Mingholy,
gwinthis,
pomelo-nwu and
tanzhenxin
as code owners
Collaborator
|
@TheForgivenOne Thanks for the fix! |
tanzhenxin
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Fixes #1748 - gopls failed to start with JSON RPC parse error. Changed the workspaceFolders capability from object
{ supported: true }to booleantruein initialize params, as gopls expects a boolean per the LSP spec.Dive Deeper
The LSP spec defines workspaceFolders as a boolean capability, not an object. gopls was rejecting the initialize request because it expected a boolean but received an object.
Reviewer Test Plan
npm install && npm run buildTesting Matrix
Linked issues / bugs
Fixes #1748